Skip to content

closes #122 add Tfrmt demographic and ae table examples #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bms63 merged 14 commits into from
Jan 16, 2026
Merged

closes #122 add Tfrmt demographic and ae table examples #133

bms63 merged 14 commits into from
Jan 16, 2026

Conversation

@alanahjonas95
Copy link
Collaborator

@alanahjonas95 alanahjonas95 commented Jan 7, 2026 •
edited
Loading

Pull Request

add add Tfrmt demographic and ae table examples to the tfl example pages
resolves #122

Before you submit your pull request, take a look at the following checklist. Many thanks for your contribution!

  • Title: Place Closes #<insert_issue_number> at the beginning of your PR title. Use the Edit button in the top-right if you need to update.
  • Linked Issue: Ensure the related issue is linked in the "Development Section" on the right-hand side.
  • First Contribution: If this is your first contribution, add yourself to the DESCRIPTION file.
  • Impact on Examples: If your updates impact any examples, review locally for warnings or errors in the impacted example pages.
  • Merge Conflicts: Developers should address any merge conflicts and merge upon successful review.
  • New Packages: If new packages were used, ensure they are included in the DESCRIPTION file's Imports section.
  • Updated Examples: If you added or updated an example, ensure it runs on the latest CRAN release versions of all packages used.
  • Testing Instructions: Provide instructions on how to test the code if necessary.

@alanahjonas95 alanahjonas95 requested a review from bms63 January 7, 2026 12:43
@alanahjonas95 alanahjonas95 changed the title 122 add Tfrmt demographic and ae table examples closes #122 add Tfrmt demographic and ae table examples Jan 7, 2026
@alanahjonas95 alanahjonas95 requested a review from bzkrouse January 7, 2026 13:32
@bms63
Copy link
Collaborator

bms63 commented Jan 7, 2026

@pharmaverse/examples hey all - looking to get a fresh set of eyes on this update as I use this package a lot at GSK...great to have a new perspective.

bms63
bms63 reviewed Jan 12, 2026
View reviewed changes
Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pharmaverse/examples is there a way to add further toc breakdown, e..g

Demographic Tables

  • rtables & tern
  • {gtsummary} & {cards}
  • tfrmt & cards?
Image

@bms63
Copy link
Collaborator

bms63 commented Jan 12, 2026

@alanahjonas95 this looks great to me.

@bzkrouse and @pharmaverse/examples is there any appetite to showcase how to render the TLFs as say pdfs or something else? maybe a showcase of docorator and other rendering packages?

@jeffreyad
Copy link
Collaborator

jeffreyad commented Jan 12, 2026 •
edited
Loading

@pharmaverse/examples is there a way to add further toc breakdown, e..g

Demographic Tables

  • rtables & tern
  • {gtsummary} & {cards}
  • tfrmt & cards?
Image

I could finish my PR #116 We discussed having TLG and TLG+ARD

@rossfarrugia
Copy link
Contributor

rossfarrugia commented Jan 13, 2026

@bzkrouse and @pharmaverse/examples is there any appetite to showcase how to render the TLFs as say pdfs or something else? maybe a showcase of docorator and other rendering packages?

Anyone could add to this article: https://pharmaverse.github.io/examples/digit_files/docx.html

@bms63
Copy link
Collaborator

bms63 commented Jan 13, 2026

@pharmaverse/examples is there a way to add further toc breakdown, e..g
Demographic Tables

  • rtables & tern
  • {gtsummary} & {cards}
  • tfrmt & cards?
Image

I could finish my PR #116 We discussed having TLG and TLG+ARD

ummm... im not really sure what to do here.

personally, I think we should increase the depth of the ToC so users can see the possible options. is that part of your udpate @jeffreyad ?

@jeffreyad
Copy link
Collaborator

jeffreyad commented Jan 13, 2026

I could finish my PR #116 We discussed having TLG and TLG+ARD

ummm... im not really sure what to do here.

personally, I think we should increase the depth of the ToC so users can see the possible options. is that part of your udpate @jeffreyad ?

We talked about adding ARD + TLG section, so that would add one more section to contents on the left. This PR would add to ARD+TLG with the AE example and would update the demographic example in ARD+TLG. The demographic TLG only would have the second example in TLG demographic with "The first and third" in ARD+TLG.

jeffreyad
jeffreyad requested changes Jan 14, 2026
View reviewed changes
alanahjonas95 and others added 4 commits January 15, 2026 11:18
@alanahjonas95 @jeffreyad
Update tlg/adverse_events.qmd
6a41c55 
Co-authored-by: Jeff Dickinson <[email protected]>
@alanahjonas95 @jeffreyad
Update tlg/adverse_events.qmd
3299de8 
Co-authored-by: Jeff Dickinson <[email protected]>
@alanahjonas95 @jeffreyad
Update tlg/demographic.qmd
0d4f23f 
Co-authored-by: Jeff Dickinson <[email protected]>
@alanahjonas95 @jeffreyad
Update tlg/adverse_events.qmd
daec71d 
Co-authored-by: Jeff Dickinson <[email protected]>
@jeffreyad
Copy link
Collaborator

jeffreyad commented Jan 15, 2026

@alanahjonas95 if you render the updated .qmd files the R scripts adverse_events.R and demographic.R will also be updated with the changes.

@alanahjonas95
Copy link
Collaborator Author

alanahjonas95 commented Jan 16, 2026

@alanahjonas95 if you render the updated .qmd files the R scripts adverse_events.R and demographic.R will also be updated with the changes.

rendered those files now :)

bms63
bms63 approved these changes Jan 16, 2026
View reviewed changes
Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in and go live!

@bms63 bms63 merged commit 1222a9d into main Jan 16, 2026
5 checks passed
@bms63 bms63 deleted the tfrmt_example branch January 16, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bms63 bms63 bms63 approved these changes

@jeffreyad jeffreyad jeffreyad approved these changes

@bzkrouse bzkrouse Awaiting requested review from bzkrouse

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use of tfrmt and docorator in TLG examples

5 participants

@alanahjonas95 @bms63 @jeffreyad @rossfarrugia